Selaa lähdekoodia

Rename minimum/maximum to min/max, type to Number

Mathieu DARTIGUES 8 vuotta sitten
vanhempi
commit
dfddd5d857

+ 2 - 2
packages/checkbox/src/checkbox-group.vue

@@ -10,8 +10,8 @@
 
     props: {
       value: {},
-      minimum: String,
-      maximum: String
+      min: Number,
+      max: Number
     },
 
     watch: {

+ 4 - 4
packages/checkbox/src/checkbox.vue

@@ -67,12 +67,12 @@
         set(val) {
           if (this.isGroup) {
             let isLimitExceeded = false;
-            (this._checkboxGroup.minimum !== undefined &&
-              val.length < this._checkboxGroup.minimum &&
+            (this._checkboxGroup.min !== undefined &&
+              val.length < this._checkboxGroup.min &&
               (isLimitExceeded = true));
 
-            (this._checkboxGroup.maximum !== undefined &&
-              val.length > this._checkboxGroup.maximum &&
+            (this._checkboxGroup.max !== undefined &&
+              val.length > this._checkboxGroup.max &&
               (isLimitExceeded = true));
 
             isLimitExceeded === false &&

+ 2 - 2
test/unit/specs/checkbox.spec.js

@@ -73,8 +73,8 @@ describe('Checkbox', () => {
       template: `
         <el-checkbox-group 
           v-model="checkList" 
-          minimum="1" 
-          maximum="2"
+          :min="1" 
+          :max="2"
         >
           <el-checkbox label="a" ref="a"></el-checkbox>
           <el-checkbox label="b" ref="b"></el-checkbox>